Andreas Rheinhardt (12021-08-12): > This can be enabled/disabled on a per-filter basis by setting > the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS. > > Signed-off-by: Andreas Rheinhardt <[email protected]> > --- > It would be possible to only free the names of non-static pads; > it could then be used with the headphone and afir filters. > But I don't think the additional complexity is worth it.
I agree on principle. But I think it would be cleaner to implement it with a per-pad flag. We could replace the needs_writable field by a flags field, with NEEDS_WRITABLE as the first flag and FREE_NAME as a new flag. That way, you do not need to distinguish input and output pads in the surrounding code. But since you already wrote the code, I will not insist if you prefer to keep it as it is. Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
