On 8/7/2021 1:06 PM, Derek Buitenhuis wrote:
On 8/6/2021 7:04 PM, James Almer wrote:
From: Matthieu Patou <[email protected]>
Suggested-by: [email protected]
Signed-off-by: James Almer <[email protected]>
---
fftools/cmdutils.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
What exactly is the point of this?
You've provided a patch with no explanation for its value.
If it's "security", then that's kind of dumb, since if you
have access to run ffmpeg on something, you have access to
`strings $(which ffmpeg)` too.
It's just to reduce the amount of information printed by default. Most
command line utilities don't bother showing build time configuration
options outside of --version or --help output, if at all.
And the string is obviously in the binary (duplicated on every library
at that), so it's not about hiding anything.
I made the latest version print it on verbose level or higher (and
always with --version), which may be preferable. But i nonetheless don't
have a strong opinion about this change.
- Derek
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
