LGTM?
On Thu, Jun 17, 2021 at 10:21 PM Mohammad Izadi <[email protected]> wrote: > > > On Thu, Jun 17, 2021 at 1:04 PM James Zern <[email protected]> > wrote: > >> On Wed, Jun 16, 2021 at 3:53 PM Mohammad Izadi >> <[email protected]> wrote: >> > >> > HDR10+ metadata is stored in the bit stream for HEVC. The story is >> different for VP9 and cannot store the metadata in the bit stream. HDR10+ >> should be passed to packet side data an stored in the container (mkv) for >> VP9. >> > >> > This CL is taking HDR10+ from AVFrame side data in libvpxenc and is >> passing it to the AVPacket side data. >> > --- >> > doc/APIchanges | 2 + >> > libavcodec/avpacket.c | 1 + >> > libavcodec/decode.c | 1 + >> > libavcodec/libvpxenc.c | 91 ++++++++++++++++++++++++++++++++++++++++++ >> > libavcodec/packet.h | 8 ++++ >> > libavcodec/version.h | 4 +- >> > 6 files changed, 105 insertions(+), 2 deletions(-) >> > >> > [...] >> > + >> > +static av_cold void free_hdr10_plus_fifo(AVFifoBuffer **fifo) >> > +{ >> > + FrameHDR10Plus frame_hdr10_plus; >> > + while (av_fifo_size(*fifo) >= sizeof(FrameHDR10Plus)) { >> > + av_fifo_generic_read(*fifo, &frame_hdr10_plus, >> sizeof(FrameHDR10Plus), NULL); >> >> use sizeof(frame_hdr10_plus) in these two cases >> > Done > >> _______________________________________________ >> ffmpeg-devel mailing list >> [email protected] >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> [email protected] with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
