> -----Original Message----- > From: ffmpeg-devel <[email protected]> On Behalf Of > [email protected] > Sent: 2021年4月27日 14:29 > To: [email protected] > Subject: Re: [FFmpeg-devel] [PATCH 4/6] tools/python: add help script to > get sess_config > > On Tue, Apr 27, 2021 at 04:25:55AM +0000, Guo, Yejun wrote: > > > > > > > -----Original Message----- > > > From: Guo, Yejun > > > Sent: 2021年4月27日 12:11 > > > To: FFmpeg development discussions and patches > > > <[email protected]> > > > Subject: RE: [FFmpeg-devel] [PATCH 4/6] tools/python: add help script > to > > > get sess_config > > > > > > > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel <[email protected]> On Behalf > Of > > > > [email protected] > > > > Sent: 2021年4月26日 18:49 > > > > To: [email protected] > > > > Cc: Limin Wang <[email protected]> > > > > Subject: [FFmpeg-devel] [PATCH 4/6] tools/python: add help script to > get > > > > sess_config > > > > > > > > From: Limin Wang <[email protected]> > > > > > > > > Please note the byte order of the hex data is in normal order. > > > > > > > > Signed-off-by: Limin Wang <[email protected]> > > > > --- > > > > tools/python/tf_sess_config.py | 44 > > > > ++++++++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 44 insertions(+) > > > > create mode 100644 tools/python/tf_sess_config.py > > > > > > > > diff --git a/tools/python/tf_sess_config.py > > > b/tools/python/tf_sess_config.py > > > > new file mode 100644 > > > > index 0000000..e4e38bd > > > > --- /dev/null > > > > +++ b/tools/python/tf_sess_config.py > > > > @@ -0,0 +1,44 @@ > > > > > > this patch changes the order in current implementation, we'd better > > > merge patch 4 and patch 5 in a single patch, to adjust the order in one > > > patch. > > I'm OK with that. I think few people have used the option yet.
yes, but we still need to keep the patch modular. There will be misleading if people bisect the code with patch 4, without patch 5. > > > > > and, we may remove '0x' at the beginning of value, since it is no longer > > a hex value in math. It is the byte order. > > For hex string, it's preferable to prefix with '0x'. for example, '0x123' is not the value of 3+2*16+1*256, I'm afraid it is confusing. anyway, '0x' as prefix is also an option, we can output a message to explain it in python script. > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > [email protected] > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > [email protected] with subject "unsubscribe". > > -- > Thanks, > Limin Wang > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
