On Sun, Mar 21, 2021 at 4:33 PM Carl Eugen Hoyos <[email protected]> wrote:
> Am So., 21. März 2021 um 06:13 Uhr schrieb Nuo Mi <[email protected]>: > > > > Magic number 124 and ^= are not listed on the spec. > > Strictly following the spec will make a reader's life much easier. See > (9-6) for details > > But FFmpeg is not providing a reference application for the reader, > this is software actually used by real people (both as a library in > other projects and in the ffmpeg application). > > Afaict, the question is if the hevc cabac reader is faster or slower > with your patch. > It looks to me as if you are replacing one condition with two conditions. > Hi Carl, Thanks for the review. It's not a time-sensitive code. We only call them at tile/slice start. A readable code will help us fix bug easier. > > Carl Eugen _______________________________________________ > ffmpeg-devel mailing list > [email protected] > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > [email protected] with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
