> 2021年1月15日 下午8:02，Moritz Barsnick <[email protected]> 写道：
>
> On Tue, Jan 12, 2021 at 21:20:03 +0800, liuqi05 wrote:
>> - if (av_strcasecmp(pls[i]->init_section->url, url) ||
>> pls[i]->init_section->url_offset != url_offset || pls[i]->init_section->size
>> != size) {
>> + if (av_strcasecmp(pls[i]->init_section->url, url) ||
>> + pls[i]->init_section->url_offset != url_offset ||
>> + pls[i]->init_section->size != size) {
>
> Good idea, but the indentation is incorrect. The subsequent lines are
> not arguments to av_strcasecmp(), but further clauses for if().
>
> Also, you should make this change the first commit of your series which
Hi Moritz,
Do you mean this modify should be merged into the first patch?
> would make what is now your first commit, including another cosmetic
> change (added space), much more compact and easier to read.
>
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
Thanks
Steven Liu
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
