Quoting Gil Pedersen (2020-11-18 12:24:09) > This is an optimization to av_buffer_replace() to avoid a redundant allocation > when the src and dst are non-NULL. > > Instead of doing a unref + ref, the dst buffer is reused and buffer counters > updated accordingly. > > Signed-off-by: Gil Pedersen <[email protected]> > --- > libavutil/buffer.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-)
Is there a reason to think this optimization has a measurable effect on performance? The code that fiddles with buffer internals should ideally be localized in as few places as possible, your patch is spreading it. I'd like to hear some arguments for why that is worth it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
