On Mon, Nov 09, 2020 at 10:51:05PM +0800, Zhao Zhili wrote:
>
>
> > On Nov 4, 2020, at 9:37 PM, [email protected] wrote:
> >
> > From: Limin Wang <[email protected]>
> >
> > Signed-off-by: Limin Wang <[email protected]>
> > ---
> > libavformat/rtsp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> > index 49c2d52..1b876c9 100644
> > --- a/libavformat/rtsp.c
> > +++ b/libavformat/rtsp.c
> > @@ -696,7 +696,7 @@ int ff_sdp_parse(AVFormatContext *s, const char
> > *content)
> > *
> > * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line
> > * in rtpdec_xiph.c. */
> > - char buf[16384], *q;
> > + char buf[SDP_MAX_SIZE], *q;
>
> The comments before this line should be moved to where SDP_MAX_SIZE
> is defined.
Yes, I have noticed the comments also, but SDP_MAX_SIZE is more general usage
for rtpdec and rtpenc, so I don't think 16KB is necessary for Vorbis only.
I prefer to remove the comments and keep the log in comment message.
>
> > SDPParseState sdp_parse_state = { { 0 } }, *s1 = &sdp_parse_state;
> >
> > p = content;
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > [email protected]
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > [email protected] with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
