On 03/11/2020 16:51, Eoff, Ullysses A wrote:>> -----Original Message-----
From: ffmpeg-devel <[email protected]> On Behalf Of Jan Ekström
Sent: Tuesday, November 03, 2020 3:17 AM
To: FFmpeg development discussions and patches <[email protected]>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] vaapi_encode_h264: Fix setting colour
properties
On Tue, Nov 3, 2020 at 12:59 AM Mark Thompson <[email protected]> wrote:
The properties should always be set; only the presence flags want to be
conditional.
Fixes #8959.
---
Thanks for this on such short notice. Patch set LGTM, and simplifies
the logic nicely for these values (always set, only set flags if
required).
Tested the H.264 and MPEG-2 encoders locally with my X230, with and
without additional color space info with the general command mentioned
in #8959. Unfortunately I lack the hardware to test HEVC for now.
Jan
Thanks. Also...
Tested-By: Xu, Yefeng <[email protected]>
...whom also tested these patches with one of our quick internal test
suites covering 170 AVC, 73 HEVC and 30 MPEG2 cases on an ICL
platform. With the patches, tests are fixed and no new regressions
detected.
Sounds good! Applied.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
