On 8/16/20, Michael Niedermayer <[email protected]> wrote: > On Sat, Aug 15, 2020 at 07:29:40PM +0200, Paul B Mahol wrote: >> On 8/15/20, Michael Niedermayer <[email protected]> wrote: >> > On Fri, Aug 14, 2020 at 02:24:25PM +0200, Paul B Mahol wrote: >> >> On 8/14/20, Paul B Mahol <[email protected]> wrote: >> >> > On 8/13/20, Paul B Mahol <[email protected]> wrote: >> >> >> Hi, >> >> >> >> >> >> patch attached. >> >> >> >> >> >> Please review and/or benchmark, especially .asm file. >> >> >> >> >> > >> >> > Updated patch attached. >> >> > >> >> >> >> Sorry, wrong patch. >> >> >> >> New patch attached. >> > >> >> Makefile | 2 >> >> cfhd.c | 271 >> >> +++++++++++------------------------------------------ >> >> cfhd.h | 3 >> >> cfhddsp.c | 110 +++++++++++++++++++++ >> >> cfhddsp.h | 42 ++++++++ >> >> x86/Makefile | 2 >> >> x86/cfhddsp.asm | 227 >> >> ++++++++++++++++++++++++++++++++++++++++++++ >> >> x86/cfhddsp_init.c | 44 ++++++++ >> >> 8 files changed, 488 insertions(+), 213 deletions(-) >> >> 9312085fc5971774cdc8511019fa4023cf269100 >> >> 0001-avcodec-cfhd-add-x86-SIMD.patch >> >> From 874fd9e604a6dcd55cca77c7256a633e5739da77 Mon Sep 17 00:00:00 2001 >> >> From: Paul B Mahol <[email protected]> >> >> Date: Sun, 9 Aug 2020 17:47:34 +0200 >> >> Subject: [PATCH] avcodec/cfhd: add x86 SIMD >> > >> > This changes the fate checksums here >> > >> >> Are you sure you tested latest patch? > > iam sure i tested the patch i replied to. I assumed that to be the latest >
What operating system, 32bit or 64bit? > just retried: > --- ./tests/ref/fate/cfhd-3 2020-08-15 19:24:32.857427918 +0200 > +++ tests/data/fate/cfhd-3 2020-08-16 01:29:09.398576303 +0200 > @@ -3,13 +3,13 @@ > #codec_id 0: rawvideo > #dimensions 0: 496x241 > #sar 0: 0/1 > -0, 0, 0, 1, 478144, 0x1e5a0d6c > -0, 1, 1, 1, 478144, 0x1e5a0d6c > -0, 2, 2, 1, 478144, 0x1e5a0d6c > -0, 3, 3, 1, 478144, 0x88788c7d > -0, 4, 4, 1, 478144, 0x78643db8 > -0, 5, 5, 1, 478144, 0x84303909 > -0, 6, 6, 1, 478144, 0x8ddd4828 > -0, 7, 7, 1, 478144, 0xc0845d58 > -0, 8, 8, 1, 478144, 0xc0845d58 > -0, 9, 9, 1, 478144, 0xc0845d58 > +0, 0, 0, 1, 478144, 0x3a16bf21 > +0, 1, 1, 1, 478144, 0x3a16bf21 > +0, 2, 2, 1, 478144, 0x3a16bf21 > +0, 3, 3, 1, 478144, 0xcdf5a9e0 > +0, 4, 4, 1, 478144, 0xd463374a > +0, 5, 5, 1, 478144, 0x3efe52f9 > +0, 6, 6, 1, 478144, 0xdab7777e > +0, 7, 7, 1, 478144, 0xa242ae7b > +0, 8, 8, 1, 478144, 0xa242ae7b > +0, 9, 9, 1, 478144, 0xa242ae7b > Test cfhd-3 failed. Look at tests/data/fate/cfhd-3.err for details. > tests/Makefile:255: recipe for target 'fate-cfhd-3' failed > make: *** [fate-cfhd-3] Error 1 > make: *** Waiting for unfinished jobs.... > TEST film-cvid > TEST flic-af11-palette-change > --- ./tests/ref/fate/cfhd-1 2020-08-15 19:24:32.857427918 +0200 > +++ tests/data/fate/cfhd-1 2020-08-16 01:29:09.434576844 +0200 > @@ -3,13 +3,13 @@ > #codec_id 0: rawvideo > #dimensions 0: 720x480 > #sar 0: 0/1 > -0, 0, 0, 1, 1382400, 0xa3e49817 > -0, 1, 1, 1, 1382400, 0x544fdfac > -0, 2, 2, 1, 1382400, 0x84964e11 > -0, 3, 3, 1, 1382400, 0xc608c8d1 > -0, 4, 4, 1, 1382400, 0xf2f1404f > -0, 5, 5, 1, 1382400, 0x5a3100ba > -0, 6, 6, 1, 1382400, 0x3727baa9 > -0, 7, 7, 1, 1382400, 0x894f07db > -0, 8, 8, 1, 1382400, 0x3ef27d46 > -0, 9, 9, 1, 1382400, 0x1f90880d > +0, 0, 0, 1, 1382400, 0x7267a5b0 > +0, 1, 1, 1, 1382400, 0xe9fec998 > +0, 2, 2, 1, 1382400, 0xd8883a69 > +0, 3, 3, 1, 1382400, 0x756dce7c > +0, 4, 4, 1, 1382400, 0x349b63a2 > +0, 5, 5, 1, 1382400, 0x0fa92a41 > +0, 6, 6, 1, 1382400, 0x1d21d79c > +0, 7, 7, 1, 1382400, 0x327d17af > +0, 8, 8, 1, 1382400, 0xaa987c63 > +0, 9, 9, 1, 1382400, 0xab136e70 > Test cfhd-1 failed. Look at tests/data/fate/cfhd-1.err for details. > tests/Makefile:255: recipe for target 'fate-cfhd-1' failed > make: *** [fate-cfhd-1] Error 1 > --- ./tests/ref/fate/cfhd-2 2020-08-15 19:24:32.857427918 +0200 > +++ tests/data/fate/cfhd-2 2020-08-16 01:29:09.470577386 +0200 > @@ -3,13 +3,13 @@ > #codec_id 0: rawvideo > #dimensions 0: 720x480 > #sar 0: 0/1 > -0, 0, 0, 1, 2073600, 0x53fab433 > -0, 1, 1, 1, 2073600, 0x0d2b3f64 > -0, 2, 2, 1, 2073600, 0x857d1d48 > -0, 3, 3, 1, 2073600, 0xe1a7df32 > -0, 4, 4, 1, 2073600, 0x615861c1 > -0, 5, 5, 1, 2073600, 0xf6cdb0a9 > -0, 6, 6, 1, 2073600, 0x55dd9f16 > -0, 7, 7, 1, 2073600, 0x7c126a32 > -0, 8, 8, 1, 2073600, 0x53fdd4c5 > -0, 9, 9, 1, 2073600, 0x6062a4b3 > +0, 0, 0, 1, 2073600, 0x2165509d > +0, 1, 1, 1, 2073600, 0x7220c8bf > +0, 2, 2, 1, 2073600, 0x2299c247 > +0, 3, 3, 1, 2073600, 0x95c48963 > +0, 4, 4, 1, 2073600, 0x66760d3f > +0, 5, 5, 1, 2073600, 0xd9cf4d22 > +0, 6, 6, 1, 2073600, 0xd3f75a86 > +0, 7, 7, 1, 2073600, 0x9d93f981 > +0, 8, 8, 1, 2073600, 0x1e9e5137 > +0, 9, 9, 1, 2073600, 0x60f7563c > Test cfhd-2 failed. Look at tests/data/fate/cfhd-2.err for details. > tests/Makefile:255: recipe for target 'fate-cfhd-2' failed > make: *** [fate-cfhd-2] Error 1 > > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Democracy is the form of government in which you can choose your dictator > _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
