Michael Niedermayer (12020-07-16): > Signed-off-by: Michael Niedermayer <[email protected]> > --- > libswscale/tests/swscale.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c > index 845ced61bb..9c0b5a4b11 100644 > --- a/libswscale/tests/swscale.c > +++ b/libswscale/tests/swscale.c > @@ -248,7 +248,7 @@ end: > if (dstStride[i]) > av_free(dst[i]); > > - return res; > + return res & 127; > } > > static void selfTest(const uint8_t * const ref[4], int refStride[4],
This looks fragile: there is no local guarantee that res is not a multiple of 128, and changes in other parts of the code could have that effect. Better change the ultimate return value of main to !!res IMHO. Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
