On Fri, Jun 26, 2020 at 11:55:33AM +0200, Moritz Barsnick wrote:
> On Fri, Jun 26, 2020 at 17:31:36 +0800, [email protected] wrote:
> > On Fri, Jun 26, 2020 at 11:15:15AM +0200, Moritz Barsnick wrote:
> > > On Fri, Jun 12, 2020 at 07:54:28 +0800, [email protected] wrote:
> > > > + if (sd->size < uuid_size) {
> > > > + av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))",
> > > > sd->size, uuid_size);
> > >
> > > ... \n
> >
> > it didn't added \n, for \n will be added after the switch.
>
> Um. Well, sorry for underquoting (did you check your code or patch, not
> just my quote?):
Yes, I have double checked the code.
>
> > +static void dump_sei_unregistered_metadata(AVFilterContext *ctx,
> > AVFrameSideData *sd)
> > +{
> > + const int uuid_size = 16;
> > + uint8_t *user_data = sd->data;
> > + int i;
> > +
> > + if (sd->size < uuid_size) {
> > + av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))",
> > sd->size, uuid_size);
> > + return;
> > + }
>
> You return immediately, nothing will be added.
Yes, I have followed the same error process style like other metadtata error
processing.
>
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> [email protected]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> [email protected] with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
