On Sun, 23. Feb 13:47, Andriy Gelman wrote: > From: Andriy Gelman <[email protected]> > > Without this setting, bitrate and qmin/qmax options have no > affect on the s5p-mfc hardware encoder. > > Signed-off-by: Andriy Gelman <[email protected]> > --- > libavcodec/v4l2_m2m_enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c > index 859feb7bde7..0098d5314bb 100644 > --- a/libavcodec/v4l2_m2m_enc.c > +++ b/libavcodec/v4l2_m2m_enc.c > @@ -179,6 +179,7 @@ static int v4l2_prepare_encoder(V4L2m2mContext *s) > /* set ext ctrls */ > v4l2_set_ext_ctrl(s, MPEG_CID(HEADER_MODE), > MPEG_VIDEO(HEADER_MODE_SEPARATE), "header mode", 0); > v4l2_set_ext_ctrl(s, MPEG_CID(BITRATE) , avctx->bit_rate, "bit rate", 1); > + v4l2_set_ext_ctrl(s, MPEG_CID(FRAME_RC_ENABLE), 1, "frame level rate > control", 0); > v4l2_set_ext_ctrl(s, MPEG_CID(GOP_SIZE), avctx->gop_size,"gop size", 1); > > av_log(avctx, AV_LOG_DEBUG, > -- > 2.25.0 >
This patch was reviewed by Ming Qian <[email protected]>: > Lgtm, > Would you please set bitrate mode to cbr by default too, for some driver, if > the default mode is vbr, the rc may be not token effect I'll apply this evening if no one objects. -- Andriy _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
