> From: ffmpeg-devel <[email protected]> On Behalf Of > Anton Khirnov > Sent: Tuesday, April 14, 2020 19:11 > To: FFmpeg development discussions and patches <ffmpeg- > [email protected]> > Subject: Re: [FFmpeg-devel] [PATCH v3 5/9] lavc/libopenh264enc: set > slice_mode option to deprecated > > Quoting Linjie Fu (2020-04-11 12:03:35) > > "slice mode" seems to be unnecessary since it could be determined by > > -slices/max_nal_size. > > > > default: SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. > > -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. > > -max_nal_size: SM_SIZELIMITED_SLICE mode with limited size slices. > > > > Add OPENH264_API_SLICE_MODE to remove this option after > > LIBAVCODEC_VERSION_MAJOR = 59. > > > > Signed-off-by: Linjie Fu <[email protected]> > > --- > > libavcodec/libopenh264enc.c | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c > > index e556f03..3a642f0 100644 > > --- a/libavcodec/libopenh264enc.c > > +++ b/libavcodec/libopenh264enc.c > > @@ -33,6 +33,10 @@ > > #include "internal.h" > > #include "libopenh264.h" > > > > +#ifndef OPENH264_API_SLICE_MODE > > +#define OPENH264_API_SLICE_MODE > (LIBAVCODEC_VERSION_MAJOR < 59) > > +#endif > > This should be moved to libavcodec/version.h with an FF_ prefix, so that > it's not overlooked when we bump the version.
Moved the macro to version.h and resend the whole patch set as V4. https://patchwork.ffmpeg.org/project/ffmpeg/patch/[email protected]/ https://patchwork.ffmpeg.org/project/ffmpeg/patch/[email protected]/ > Otherwise looks ok Thanks for the review. - Linjie _______________________________________________ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email [email protected] with subject "unsubscribe".
