On Sat, Nov 29, 2014 at 03:26:08AM +0100, Alexander Strasser wrote: > Hi, > > while reading the recent evolution of xbr I came up with the > idea for below 2 patches. > > Maybe I am missing something, but AFAICT both filters use > a single shared filter function for n in [2, 4] using n as a param > but n is stored in the filter context too. The corresponding fate > tests and visual inspection show no differences. > > It sure is a matter of taste, so I guess it is your call Clément. > > Alexander Strasser (2): > lavfi/vf_xbr: Remove function generator macro and function pointer > indirection > lavfi/vf_hqx: Remove function generator macro and function pointer > indirection > > libavfilter/vf_hqx.c | 35 +++++++++++------------------------ > libavfilter/vf_xbr.c | 33 ++++++++++-----------------------
NACK This probably kills the performances badly. The purpose of this indirection is to create N functions optimized for a specific size. Best regards, -- Clément B.
pgpbIRSAiC63l.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
