On Tue, Jan 29, 2002 at 07:19:59PM -0800, Guy Harris wrote: > > > It also kind of bugs me that the > > > smb dissector can append text to the info field after the subdissector > > > has handled the packet. > > > > Yes, that's definitely wrong. > > ...but if we don't call a subdissector, it's OK. > > I don't know whether, for SMBs that *don't* encapsulate other protocols, > we should move the "Error: XXX" stuff before any stuff added by the > dissector for that particular SMB; that's a side-effect of your patch.
Yes that's true - it might mess up the layout of the info column for plain smb packets. Changing the return value of smb_dissect seems it bit yucky too. )-:
