barbieri pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=9486225744efdc9a68813f0d34f4e38e04387567

commit 9486225744efdc9a68813f0d34f4e38e04387567
Author: Gustavo Sverzut Barbieri <[email protected]>
Date:   Tue Mar 28 15:25:39 2017 -0300

    ecore_con: remove warnings if FD_CLOEXEC is undefined.
    
    currently it's being defined in evil_fcntl.h, but the actual
    implementation of fcntl() in evil_fcntl.c is causing problems with
    sockets. So one possibility is to remove the ifdef, another is to
    change the implementation.
---
 src/lib/ecore_con/ecore_con.c         | 3 +++
 src/lib/ecore_con/efl_net_server_fd.c | 8 ++++++++
 2 files changed, 11 insertions(+)

diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c
index 6ab3276..64ac60f 100644
--- a/src/lib/ecore_con/ecore_con.c
+++ b/src/lib/ecore_con/ecore_con.c
@@ -598,6 +598,9 @@ efl_net_socket4(int domain, int type, int protocol, 
Eina_Bool close_on_exec)
           }
      }
    EINA_THREAD_CLEANUP_POP(EINA_FALSE); /* we need fd on success */
+#else
+   DBG("close on exec is not supported on your platform");
+   (void)close_on_exec;
 #endif
 
    return fd;
diff --git a/src/lib/ecore_con/efl_net_server_fd.c 
b/src/lib/ecore_con/efl_net_server_fd.c
index deb1962..0c76af2 100644
--- a/src/lib/ecore_con/efl_net_server_fd.c
+++ b/src/lib/ecore_con/efl_net_server_fd.c
@@ -60,6 +60,8 @@ efl_net_accept4(SOCKET fd, struct sockaddr *addr, socklen_t 
*addrlen, Eina_Bool
              return INVALID_SOCKET;
           }
      }
+#else
+   (void)close_on_exec;
 #endif
 
    return client;
@@ -295,6 +297,10 @@ _efl_net_server_fd_close_on_exec_set(Eo *o, 
Efl_Net_Server_Fd_Data *pd, Eina_Boo
         pd->close_on_exec = old;
         return EINA_FALSE;
      }
+#else
+   DBG("close on exec is not supported on your platform");
+   (void)close_on_exec;
+   (void)o;
 #endif
 
    return EINA_TRUE;
@@ -321,6 +327,8 @@ _efl_net_server_fd_close_on_exec_get(Eo *o, 
Efl_Net_Server_Fd_Data *pd)
      }
 
    pd->close_on_exec = !!(flags & FD_CLOEXEC); /* sync */
+#else
+   (void)o;
 #endif
    return pd->close_on_exec;
 }

-- 


Reply via email to