devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=a89186069ed816e6e6cf04aa8502dbfda4128707
commit a89186069ed816e6e6cf04aa8502dbfda4128707 Author: Chris Michael <[email protected]> Date: Thu Jul 21 12:58:03 2016 -0400 elementary: Remove logically dead code Coverity reports that this is logically dead code. As we check the validity of 'model' above this function, then testing 'model' for validity again in this expression is just logically dead. Fixes Coverity CID1356617 @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/elementary/elc_fileselector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elc_fileselector.c b/src/lib/elementary/elc_fileselector.c index 095ad3a..566aa1e 100644 --- a/src/lib/elementary/elc_fileselector.c +++ b/src/lib/elementary/elc_fileselector.c @@ -102,7 +102,7 @@ _elm_fileselector_replace_model(Elm_Fileselector *fs, Elm_Fileselector_Data *sd, if (model && path) { - sd->model = model ? eo_ref(model) : NULL; + sd->model = eo_ref(model); eina_stringshare_replace(&sd->path, path); _monitoring_start(fs, sd, sd->model); /* TODO: sub directory should be monitored for expand mode */ --
