cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f803ba27b7a394f1b9ab83e3e7b760e6e916fbbd
commit f803ba27b7a394f1b9ab83e3e7b760e6e916fbbd Author: wonguk.jeong <[email protected]> Date: Mon Jul 7 19:10:58 2014 +0200 ethumb: fix setup related API problem Summary: setup related API was not working at all due to below problems 1. dbus type signature is wrong. it's array of dictionary not array of struct 2. since quality value was assigned to compress value, there was a problem during saving png image (out of bound) 3. orientation_set API was not working except NONE and ORIGINAL @fix Test Plan: make thumbnail by using elm_thumb_add -> orientation set to 90 CCW -> check whether image is rotated properly or not Reviewers: raster, cedric CC: seoz, cedric Differential Revision: https://phab.enlightenment.org/D1138 Signed-off-by: Cedric BAIL <[email protected]> --- src/bin/ethumb_client/ethumbd.c | 2 +- src/lib/ethumb/ethumb.c | 2 ++ src/lib/ethumb_client/ethumb_client.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bin/ethumb_client/ethumbd.c b/src/bin/ethumb_client/ethumbd.c index 1b757db..5e09590 100644 --- a/src/bin/ethumb_client/ethumbd.c +++ b/src/bin/ethumb_client/ethumbd.c @@ -1638,7 +1638,7 @@ _ethumb_dbus_ethumb_setup_cb(const Eldbus_Service_Interface *iface, const Eldbus request->id = -1; r = EINA_TRUE; - while (eldbus_message_iter_get_and_next(array, 'r', &data) && r) + while (eldbus_message_iter_get_and_next(array, 'e', &data) && r) { if (!_ethumb_dbus_ethumb_setup_parse_element(eobject, data, request)) r = EINA_FALSE; diff --git a/src/lib/ethumb/ethumb.c b/src/lib/ethumb/ethumb.c index 761d56d..76538e9 100644 --- a/src/lib/ethumb/ethumb.c +++ b/src/lib/ethumb/ethumb.c @@ -1611,6 +1611,8 @@ _ethumb_image_load(Ethumb *e) } #endif } + else + orientation = e->orientation; if (orientation != ETHUMB_THUMB_ORIENT_NONE) _ethumb_image_orient(e, orientation); diff --git a/src/lib/ethumb_client/ethumb_client.c b/src/lib/ethumb_client/ethumb_client.c index 5524370..cec7e76 100644 --- a/src/lib/ethumb_client/ethumb_client.c +++ b/src/lib/ethumb_client/ethumb_client.c @@ -817,7 +817,7 @@ ethumb_client_ethumb_setup(Ethumb_Client *client) _setup_iterator_close(array, entry, variant); variant = _setup_iterator_open(array, &entry, "compress", "i"); - compress = ethumb_thumb_quality_get(e); + compress = ethumb_thumb_compress_get(e); eldbus_message_iter_arguments_append(variant, "i", compress); _setup_iterator_close(array, entry, variant); --
