On Thu, 16 Jun 2011 06:35:25 +0200 Ulrich Eckhardt <[email protected]> said:
ok - it's in svn. as such patch is acceptable as it doesnt break binary compat. it just permanently makes the ecore_evas xrender calls error/do nothing which is what they would do without an xrender engine in evas anyway. so patch is acceptable. put in svn with changelog added etc. thanks! :) > On Saturday 11 June 2011 16:43:55 Christopher Michael wrote: > > On 06/11/2011 06:11 AM, Ulrich Eckhardt wrote: > > > On Saturday 11 June 2011 10:19:40 Ulrich Eckhardt wrote: > > >> I'm trying to create a patch which does just that, which I'll post > > >> lateron. > > > > > > Here it comes. > > > > > > There are a few observations which I'm not sure how to resolve: > > > 1. configure.ac > > > There is a check for the Xcursor support, which uses "-l Xrender" as > > > additional library. I wonder if that is necessary. > > > > That is the X11 XRender Extenstion, not the same as the evas/ecore X > > Render Engine. Yes, that check is necessary. XCursor uses the XRender > > extension to check if the screen supports alpha. > > Okay, the patch didn't touch that anyway. > > > > 3. ecore_x > > > This uses XRender when ECORE_XRENDER is defined and looking at > > > _ecore_x_composite_init() it seems to really want that. I'm not sure how > > > to handle that case, so I left all that in and really only adapted the > > > ecore_evas part. > > > > Same case as above, ecore_x_composite_init uses the X11 XRender > > Extension (not the same as the evas/ecore xrender engine). > > Neither did the patch touch these parts. > > > > 2. ecore_evas > > > There is a switch over the different engine types, where there are still > > > a few places left where XRender is handled, grep for "xrender" or > > > "XRENDER" and you will find them. The question is whether to just return > > > NULL in order to signal that this engine is not supported or to remove > > > the whole thing. The latter could break binary compatibility, therefore > > > I left those stubs in. > > Question remains is if the changes to ecore_evas are acceptable or if even > the remaining places should be removed. > > Thanks! > > Uli > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
