2008/10/6 Gustavo Sverzut Barbieri <[EMAIL PROTECTED]>: > On Sun, Sep 21, 2008 at 7:29 PM, Hendrik Siedelmann > <[EMAIL PROTECTED]> wrote: >> Okay here it is, this patch adds the possibility to epsilon to create >> thumbnails in jpg format. The thumbnails are saved in FDO naming >> convention, just with ending .jpg. Would be glad if you could give me >> some feedback so this could eventually be included in svn. Patch works >> for me, but there are some things to mention: > > Ok, better late than sorry, it's commited to SVN. As for your questions:
Now that is great news, thanks. >> - default behaviour is like before, BUT epsilon_exists will also find >> jpg thumbs, so epsilon_thumb_file_get will return the jpg and >> epsilon_info_get will return nothing as the jpg contains no exif >> infos. >> >> - I don't know what happens in those HAVE_EPEG_H parts, only tested >> without epeg. > > EPEG was the old way to generate JPEGs in an efficient way. Then that > code was integrated into Evas, then I deprecated EPEG (moved to OLD) > when we changed to SVN. > > At the beginning, epsilon was not using Evas, but raster added that, > but I never checked that it was not generating JPEGs, just PNGs > because there was no option to select so. So is it save to assume epeg is never used and remove those parts? >> - new function epsilon_format_set which allows to set format to jpeg. > > It would be good to provide patch for > BINDINGS/python-efl/python-epsilon. If you are able to provide so, > mail it, otherwise I can do it for you. Sorry, never worked with python. >> - also changed epsilon_thumbd and added function >> epsilon_request_add_advanced which can also set format (and in the >> future hopefully custom sizes). >> >> - changed epsilon_thumb_test to accept the arguments -large and -jpg >> to request thumbnails with these options. >> >> >From my test the jpg output is at least two times as fast on my laptop >> and at least five times on the the freerunner. Also the resulting >> files are 10-20% the size of png thumbnails. > > yes, raster already provided such feedback to fdo guys, but they > blindly rejected so... damn it. Yeah would have been nice to have jpeg in the standard. But the way the jpegs are saved now makes it dead easy to implement for all programs that support the fdo spec. hendrik ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
