Hi,
This patch avoids a segv when we click open in the icon chooser without
selecting a file.
Stafford
Index: icon_chooser.c
===================================================================
RCS file: /cvsroot/enlightenment/e16/tools/e16menuedit2/src/icon_chooser.c,v
retrieving revision 1.4
diff -u -r1.4 icon_chooser.c
--- icon_chooser.c 15 Jan 2005 18:39:11 -0000 1.4
+++ icon_chooser.c 16 Jan 2005 09:47:15 -0000
@@ -131,7 +131,8 @@
model = gtk_tree_view_get_model (GTK_TREE_VIEW (treeview_menu));
select = gtk_tree_view_get_selection (GTK_TREE_VIEW (treeview_menu));
- if (gtk_tree_selection_get_selected (select, &model, &iter))
+ if (gtk_tree_selection_get_selected (select, &model, &iter)
+ && filename != NULL)
{
const gchar *entry_select;
gint width, height;
@@ -253,10 +254,6 @@
/* delete current icon */
case GTK_RESPONSE_REJECT:
{
- gchar *filename;
-
- filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (filechooser));
-
model = gtk_tree_view_get_model (GTK_TREE_VIEW (treeview_menu));
select = gtk_tree_view_get_selection (GTK_TREE_VIEW (treeview_menu));
@@ -277,8 +274,6 @@
-1);
}
-
- g_free (filename);
break;
}
}
