Allon Mureinik has uploaded a new change for review.
Change subject: core: VdcActionUtils: Remove null check
......................................................................
core: VdcActionUtils: Remove null check
Removed a redundant null check from VdcActionUtils.getStatusProperty.
getStatusProperty is a private method, only called from canExecute.
Before applying getStatusProperty to a, a.getClass() is called, meaning
that a is clearly not null, and therefore this check is redundant.
Change-Id: I07bc2eeabe676bad8175010100e24bfd9fc05d31
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/18854/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
index 9087d9b..8d9cafb 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
@@ -307,10 +307,6 @@
}
private static Enum<?> getStatusProperty(Object entity) {
- if (entity == null) {
- return null;
- }
-
if (entity.getClass().getName().endsWith("VDS")) {
return entity instanceof VDS ?
((VDS) entity).getStatus() :
--
To view, visit http://gerrit.ovirt.org/18854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07bc2eeabe676bad8175010100e24bfd9fc05d31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
