Allon Mureinik has uploaded a new change for review. Change subject: core: VdcActionUtils: declare variables as Maps ......................................................................
core: VdcActionUtils: declare variables as Maps Declared variables as Maps instead of HashMaps, as per proper abstraction guidelines. Change-Id: I8e73672a57cad5c051ec875eef22e2d5f846eab5 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/18851/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java index 0c8ad03..bc8a16f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java @@ -25,7 +25,7 @@ static { // this matrix contains the actions that CANNOT run per status // ("black list") - HashMap<Enum<?>, Set<VdcActionType>> vdsMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); + Map<Enum<?>, Set<VdcActionType>> vdsMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); vdsMatrix.put( VDSStatus.Maintenance, EnumSet.of(VdcActionType.MaintenanceVds, VdcActionType.ClearNonResponsiveVdsVms, @@ -98,7 +98,7 @@ EnumSet.of(VdcActionType.ActivateVds, VdcActionType.ApproveVds, VdcActionType.RefreshHostCapabilities)); _matrix.put(VDS.class, vdsMatrix); - HashMap<Enum<?>, Set<VdcActionType>> vmMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); + Map<Enum<?>, Set<VdcActionType>> vmMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); vmMatrix.put( VMStatus.WaitForLaunch, EnumSet.of(VdcActionType.HibernateVm, VdcActionType.RunVm, @@ -254,7 +254,7 @@ VdcActionType.RemoveVmInterface, VdcActionType.CancelMigrateVm, VdcActionType.ExtendImageSize)); _matrix.put(VM.class, vmMatrix); - HashMap<Enum<?>, Set<VdcActionType>> vmTemplateMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); + Map<Enum<?>, Set<VdcActionType>> vmTemplateMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); vmTemplateMatrix.put( VmTemplateStatus.Locked, EnumSet.of(VdcActionType.RemoveVmTemplate, @@ -266,7 +266,7 @@ VdcActionType.MoveOrCopyTemplate, VdcActionType.ImportVmTemplate)); _matrix.put(VmTemplate.class, vmTemplateMatrix); - HashMap<Enum<?>, Set<VdcActionType>> storageDomainMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); + Map<Enum<?>, Set<VdcActionType>> storageDomainMatrix = new HashMap<Enum<?>, Set<VdcActionType>>(); storageDomainMatrix.put( StorageDomainStatus.Active, EnumSet.of(VdcActionType.DetachStorageDomainFromPool, VdcActionType.ActivateStorageDomain)); -- To view, visit http://gerrit.ovirt.org/18851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e73672a57cad5c051ec875eef22e2d5f846eab5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches