Alon Bar-Lev has posted comments on this change. Change subject: packaging: use $0 instead of hardcoding script name when calling engine-upgrade ......................................................................
Patch Set 2: (1 comment) well, you can also argue that the fact that rhevm-setup is executed and you see engine-setup later on is confusing... or rhevm-setup --help... etc... so I don't think this is required... however, small note for sh .................................................... File packaging/bin/engine-upgrade.sh Line 1: #!/bin/sh Line 2: Line 3: cat >&2 <<__EOF__ Line 4: `basename $0` is obsoleted by engine-setup. $(basename "$0") Line 5: please run engine-setup for upgrading product or update settings. Line 6: __EOF__ Line 7: -- To view, visit http://gerrit.ovirt.org/18787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1b517a1f5126161bffaf4d3efcfc0fabfa443a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
