Vitor de Lima has posted comments on this change.

Change subject: core: Add POWER 7 to the CPU list
......................................................................


Patch Set 4:

(2 comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java
Line 6: 
Line 7:     ppc64,
Line 8:     x86_64,
Line 9:     undefined;
Line 10: 
The default cluster and the blank template have undefined architectures.
Line 11:     public static String nameOf(ArchitectureType architecture) {
Line 12:         if (architecture == null) {
Line 13:             return ArchitectureType.undefined.name();
Line 14:         }


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java
Line 61:     public ArchitectureType getArchitecture() {
Line 62:         return architectureType;
Line 63:     }
Line 64: 
Line 65:     public void setArchitecture(ArchitectureType architectureType) {
I don't think so, but every attribute of this class has a getter and a setter, 
so I followed that convention.
Line 66:         this.architectureType = architectureType;
Line 67:     }


-- 
To view, visit http://gerrit.ovirt.org/17853
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to