Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Stopped progress bar after initializing network list
......................................................................

webadmin: Stopped progress bar after initializing network list

The code didn't stop the progress bar, so when a DC was selected in
the system tree (rather than a network) the progress bar would
continue indefinitely when the dialog was opened.

Change-Id: I469e4d95e479c99f5315fbc89f369e254b16cfd9
Bug-Url: https://bugzilla.redhat.com/1001000
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/18782/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
index 6e5ca5b..d93fed7 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileListModel.java
@@ -106,8 +106,6 @@
     }
 
     private void initNetworkList(final VnicProfileModel profileModel) {
-        profileModel.startProgress(null);
-
         SystemTreeItemModel treeSelectedItem =
                 (SystemTreeItemModel) 
CommonModel.getInstance().getSystemTree().getSelectedItem();
 
@@ -125,6 +123,7 @@
                 treeSelectedItem.getType() == SystemTreeItemType.DataCenter ? 
treeSelectedItem : null;
 
         if (treeSelectedDc != null) {
+            profileModel.startProgress(null);
             StoragePool dc = (StoragePool) treeSelectedDc.getEntity();
 
             AsyncQuery _asyncQuery = new AsyncQuery();
@@ -146,6 +145,8 @@
                     } else {
                         
profileModel.getNetwork().setSelectedItem(Linq.firstOrDefault(networks));
                     }
+
+                    profileModel.stopProgress();
                 }
             };
 


-- 
To view, visit http://gerrit.ovirt.org/18782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I469e4d95e479c99f5315fbc89f369e254b16cfd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to