Shubhendu Tripathi has posted comments on this change. Change subject: db: fix upgrade for app mode to roles ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/dbscripts/upgrade/03_03_0810_add_app_mode_to_roles.sql Line 8: Line 9: select fn_db_add_column('roles', 'app_mode', 'INTEGER'); Line 10: Line 11: UPDATE roles Line 12: SET app_mode = (CASE WHEN name in ('UserRole', 'PowerUserRole', 'DataCenterAdmin', 'StorageAdmin', 'UserVmManager', 'VmPoolAdmin', 'TemplateAdmin', 'TemplateUser', 'QuotaConsumer', 'TemplateOwner', 'DiskOperator', 'DiskCreator', 'VmCreator', 'TemplateCreator', 'VnicProfileUser', 'UserTemplateBasedVm') When does the role UserTemplateBasedVm get added to DB? I did not see the same and hence not having in upgrade script. Line 13: THEN 1 Line 14: WHEN name='GlusterAdmin' Line 15: THEN 2 Line 16: WHEN name in ('ClusterAdmin', 'SuperUser', 'HostAdmin', 'NetworkAdmin', 'ExternalEventsCreator', 'ExternalTasksCreator') -- To view, visit http://gerrit.ovirt.org/18777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ebbba79deb6de091d27621196f361fd4fd3caf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches