Federico Simoncelli has posted comments on this change. Change subject: webadmin: avoid disconnect server on attach domain ......................................................................
Patch Set 1: > The meaning of this patch is that when we attach a domain to a DC, even if we > never activate it, there will be a lingering storage server connection. I don't see this in the code, it is probably just an assumption given that we remove a "DisconnectStorageServerConnection". 1. importFileStorageAddDomain is used in one place only (I don't see any other code relying on this code for "attach not activated") 2. if a domain is attached its connection is not lingering even if the domain is inactive (meaning that it's not the active/inactive state that determines the connect/disconnect) 3. connect/disconnect are handled (rightly) on the engine side by AddExistingFileStorageDomain 4. the only problem here is that if AddExistingFileStorageDomain fails we still have the server connection defined in the database (but this has nothing to do with connect/disconnect). We could try to catch the error and cleanup but this is out of scope of the bug and it should be added to the long list of things broken in this flow (some are mentioned in the commit message). -- To view, visit http://gerrit.ovirt.org/18649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie880c25014c5292ad64ed94ad9c126fdd048d7bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
