Roy Golan has posted comments on this change. Change subject: core: New OS for IBM POWER support ......................................................................
Patch Set 1: Code-Review+1 (2 comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java Line 21: WINDOWS_XP, Line 22: WINDOWS_2003, Line 23: WINDOWS_2008, Line 24: OTHER_LINUX, Line 25: OTHER_PPC64, no need to add it here. the list of supported values for the REST is already taken from the OsRepository directly. this enum is here for backward compatibility purposes Line 26: OTHER, Line 27: RHEL_5, Line 28: RHEL_4, Line 29: RHEL_3, .................................................... File packaging/conf/osinfo-defaults.properties Line 66: os.other_ppc64.resources.minimum.numberOsCpus.value = 1 Line 67: os.other_ppc64.spiceSupport.value = false Line 68: os.other_ppc64.devices.audio.value = ich6 Line 69: os.other_ppc64.devices.network.value = rtl8139, pv Line 70: os.other_ppc64.devices.diskInterfaces.value = VirtIO, VirtIO_SCSI best practice is to inherit "other" and override whatever you need so every new attribute introduced is inherited. os.other_ppc64.derivedFrom.value = other Line 71: Line 72: os.linux.id.value = 100 Line 73: os.linux.name.value = Linux Line 74: os.linux.derivedFrom.value = other -- To view, visit http://gerrit.ovirt.org/18220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35298c31cfa55f212c2d8b4016ee3019d7b28c40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
