Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: do not mark iptables unremovable if not actually used ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 217 Line 218 Line 219 Line 220 Line 221 I'd personally move also the 3 lines above inside _iptablesmark - it's not related to processing templates either. -- To view, visit http://gerrit.ovirt.org/18740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I682c001567e3271fa6a10e166d9c2b83fc643995 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
