Oved Ourfali has posted comments on this change.
Change subject: core: Fill and check arch when importing VM and Template
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Consider doing what I suggested in the comment.
Other than that, and Michal's comment, it looks okay.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 56:
_vm.setArchitecture(osRepository.getArchitectureFromOS(osId));
Line 57: }
Line 58: else {
Line 59: _vm.setArchitecture(ArchitectureType.undefined);
Line 60: }
Perhaps you can put a method in OvfReader that does that, and use it in both
OvfVmReader and OvfTemplateReader?
Consider that.
Line 61: }
Line 62:
Line 63: @Override
Line 64: protected void readHardwareSection(XmlNode section) {
--
To view, visit http://gerrit.ovirt.org/18702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac6093e253225f801e216310828a7afba73f9e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
