Daniel Erez has posted comments on this change. Change subject: webadmin: Warning about storage format upgrade ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java Line 616: .changeDataCenterCompatibilityVersionTitle()); Line 617: confirmModel.setHashName("change_data_center_compatibility_version"); //$NON-NLS-1$ Line 618: Line 619: StorageFormatType newFormat = VersionStorageFormatUtil.getFormatForVersion((Version) model.getVersion().getSelectedItem()); Line 620: StorageFormatType oldFormat = VersionStorageFormatUtil.getFormatForVersion(((StoragePool) getSelectedItem()).getcompatibility_version()); formatter Line 621: if (newFormat == oldFormat) { Line 622: confirmModel.setMessage(ConstantsManager.getInstance() Line 623: .getConstants() Line 624: .youAreAboutChangeDcCompatibilityVersionMsg()); -- To view, visit http://gerrit.ovirt.org/18698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a5287ad223813ef732f7daccb2ae11af2cecc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches