[Engine-patches] Change in ovirt-engine[master]: engine: leak property file resource

[awels]

Alexander Wels has uploaded a new change for review.

Change subject: engine: leak property file resource
......................................................................

engine: leak property file resource

- Fixed resource leak in loading themes.

Change-Id: I7d66412b9b5242af8c471d4191d50a48d9eaa1e9
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/22/18722/1

diff --git 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
index 79bab40..5374554 100644
--- 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
+++ 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingTheme.java
@@ -147,7 +147,7 @@
     public boolean load() {
         final String propertiesFileName = filePath + "/" + 
BRANDING_PROPERTIES_NAME; //$NON-NLS-1$
         available = false;
-        FileInputStream propertiesFile;
+        FileInputStream propertiesFile = null;
         try {
             propertiesFile = new FileInputStream(propertiesFileName);
             brandingProperties.load(propertiesFile);
@@ -161,6 +161,14 @@
             log.warn("Unable to load properties file for " //$NON-NLS-1$
                     + "theme located here:"//$NON-NLS-1$
                     + propertiesFileName, e);
+        } finally {
+            if (propertiesFile != null) {
+                try {
+                    propertiesFile.close();
+                } catch (IOException e) {
+                    log.warn("Unable to close properties file"); //$NON-NLS-1$
+                }
+            }
         }
         return available;
     }


-- 
To view, visit http://gerrit.ovirt.org/18722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d66412b9b5242af8c471d4191d50a48d9eaa1e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches