Ramesh N has posted comments on this change.
Change subject: engine: Support for gluster task monitoring
......................................................................
Patch Set 6:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
Line 60: /**
Line 61: * @param version
Line 62: * Compatibility version to check for.
Line 63: * @return <code>true</code> if gluster host UUID is supported,
<code>false</code> if it's not.
Line 64: */
I think the comment could be changed to reflect the correct feature being
supported
Line 65: public static boolean glusterAsyncTasks(Version version) {
Line 66: return
supportedInConfig(ConfigValues.GlusterAysncTasksSupport, version);
Line 67: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 180: @Override
Line 181: public GlusterVolumeEntity getVolumeByGlusterTask(Guid taskId) {
Line 182: GlusterVolumeEntity volume = getCallsHandler().executeRead(
Line 183: "GetGlusterVolumeByGlusterTaskId", volumeRowMapper,
Line 184: getCustomMapSqlParameterSource().addValue("task_id",
taskId));
I think you have to call fetchRelatedEntities() or directly set the task
details in volume by calling getAsyncTaskOfVolume(). Otherwise task details
will not be fetched in volume entity.
Line 185: return volume;
Line 186: }
Line 187:
Line 188: @Override
....................................................
File packaging/dbscripts/gluster_volumes_sp.sql
Line 152: END; $procedure$
Line 153: LANGUAGE plpgsql;
Line 154:
Line 155: Create or replace FUNCTION GetGlusterVolumeByGlusterTaskId(v_task_id
UUID)
Line 156: RETURNS SETOF gluster_volumes_view
I think you have to give 'STABLE' flag here
Line 157: AS $procedure$
Line 158: BEGIN
Line 159: RETURN QUERY SELECT *
Line 160: FROM gluster_volumes_view
--
To view, visit http://gerrit.ovirt.org/17965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica67b56804cbb892886160f0b22043687277d476
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
