Yedidyah Bar David has posted comments on this change. Change subject: core: filetransaction: Always add a newline ......................................................................
Patch Set 1: Verified+1 Without this change, Sandro's change http://gerrit.ovirt.org/16769 creates a file without its empty last line (which the original had). setup/plugins/ovirt-engine-setup/apache/ssl.py:_editParams has a hack to force this newline which is why this line is not lost during setup. I will now do a similar thing in http://gerrit.ovirt.org/16769 but do not think that's the way to go. -- To view, visit http://gerrit.ovirt.org/18690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97f0feef1c003250c9f7453245f68398c64051cd Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
