Vitor de Lima has posted comments on this change. Change subject: engine: VM Device Type for Display Type ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/conf/osinfo-defaults.properties Line 48: os.other.devices.audio.value = ich6 Line 49: # See VmInterfaceType.java Line 50: os.other.devices.network.value = rtl8139, e1000, pv Line 51: os.other.devices.vnc.vmDeviceType.value = cirrus Line 52: os.other.devices.qxl.vmDeviceType.value = qxl This looks like a good idea. There are a few issues though, such as: * It is possible to use the QXL video in the VNC protocol * If we specify two possible options for the VNC protocol (like cirrus and vga), there must be changes in the engine both int the frontend and in the REST API to enable the end user to choose between them. * QEMU for x86 supports the VMware video card, maybe it could be included as a option Is this worth a more detailed discussion in the engine-devel mailing list? Line 53: Line 54: os.linux.id.value = 100 Line 55: os.linux.name.value = Linux Line 56: os.linux.derivedFrom.value = other -- To view, visit http://gerrit.ovirt.org/18677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f8aaf0de95332436499205f90336d2f4e73d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
