Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: modify AIA port when upgrade from legacy ......................................................................
Patch Set 1: (2 comments) .................................................... Commit Message Line 10: web server we need to modify AIA extension URL. Line 11: Line 12: this will not effect past certificate, only new certificate. Line 13: Line 14: the engine rename script may be used to refresh the engine certificate. It only updates apache's certificate, not the engine's nor jobs nor ca. It might make sense to also alert the user if the port is indeed changed, saying something similar to what we say on rename. Line 15: Line 16: Change-Id: I6d955b34497e3256528180938dc67575d7812646 .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py Line 68: with open(name, 'r') as f: Line 69: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 70: filetransaction.FileTransaction( Line 71: name=name, Line 72: content=f.read().replace( Perhaps have code similar to what's in rename? Check for "authorityInfoAccess" etc.? Line 73: replace['from'], replace['to'] Line 74: ).splitlines(), Line 75: modifiedList=self.environment[ Line 76: otopicons.CoreEnv.MODIFIED_FILES -- To view, visit http://gerrit.ovirt.org/18687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d955b34497e3256528180938dc67575d7812646 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
