Tal Nisan has posted comments on this change.
Change subject: engine: Iterate maps with entrySet()
......................................................................
Patch Set 2:
(4 comments)
Names are horrible indeed, in some of them the context is quite clear at first
sight so there won't be a problem to name them more appropriately, also added
some comments
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
Line 280
Line 281
Line 282
Line 283
Line 284
Seriously?
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNamespaceManager.java
Line 27:
Line 28: @Override
Line 29: public String getPrefix(String namespaceURI) {
Line 30: for (Map.Entry<String, String> stringStringEntry :
prefixToUri.entrySet()) {
Line 31: if (stringStringEntry.getValue().equals(namespaceURI))
Please add curly brackets to the if statement
Line 32: return stringStringEntry.getKey();
Line 33: }
Line 34:
Line 35: return null;
Line 39: public Iterator getPrefixes(String namespaceURI) {
Line 40: List<String> prefixes = new LinkedList<String>();
Line 41:
Line 42: for (Map.Entry<String, String> stringStringEntry :
prefixToUri.entrySet()) {
Line 43: if (stringStringEntry.getValue().equals(namespaceURI))
Same here
Line 44: prefixes.add(stringStringEntry.getKey());
Line 45: }
Line 46:
Line 47: return prefixes.iterator();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/OrderedMultiSelectionModel.java
Line 122: }
Line 123:
Line 124: if (!visibleKeys.containsAll(selectedKeys)) {
Line 125: for (Map.Entry<Object, T> objectTEntry :
selectedSet.entrySet()) {
Line 126: if (!visibleKeys.contains(objectTEntry.getKey()))
Please add curly brackets
Line 127: selectionChanges.put(objectTEntry.getValue(),
false);
Line 128: }
Line 129: }
Line 130:
--
To view, visit http://gerrit.ovirt.org/18654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia17710ae5dcf61779cabb892638d3d8f6ac95d86
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
