Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: process fw templates at validation
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Minor note for the TODO...

....................................................
File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
Line 179:         name=osetupcons.Stages.NET_FIREWALL_MANAGER_PROCESS_TEMPLATES,
Line 180:         # must be always enabled to create examples
Line 181:         # TODO: add:
Line 182:         # before=(
Line 183:         #    otopicons.Stages.FIREWALLD_VALIDATION,
and before IPTABLES_VALIDATION?
Line 184:         #),
Line 185:         # and remove:
Line 186:         priority=plugin.Stages.PRIORITY_HIGH,
Line 187:     )


-- 
To view, visit http://gerrit.ovirt.org/18660
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b1e89c4a263add052f3963929944554e865b71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to