Yair Zaslavsky has posted comments on this change.

Change subject: engine: BLL Command to Stop Reblance Gluster Volume task
......................................................................


Patch Set 9:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
Line 80: 
Line 81:     protected void endStepJob() {
Line 82:         GlusterAsyncTask asyncTask = getGlusterVolume().getAsyncTask();
Line 83:         // Gluster Volume Rebalance Task will have only one step ( 
REBALANCING_VOLUME )
Line 84:         Step step = 
DbFacade.getInstance().getStepDao().getStepsByExternalId(asyncTask.getTaskId()).get(0);
please introduce a getStepDao() that will perform
return DbFacade.getInstance().getStepDao()
Line 85:         step.markStepEnded(JobExecutionStatus.ABORTED);
Line 86:         
step.setDescription(ExecutionMessageDirector.resolveStepMessage(getStepType(),
Line 87:                 getStepMessageMap(JobExecutionStatus.ABORTED)));
Line 88:         JobRepositoryFactory.getJobRepository().updateStep(step);


-- 
To view, visit http://gerrit.ovirt.org/18445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7cf0eb4de160dc309f2699ba0e224f48dd1f49
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to