Juan Hernandez has uploaded a new change for review.

Change subject: core: Fix XML comments in findbugs filters
......................................................................

core: Fix XML comments in findbugs filters

The findbugs configuration file exclude-filters-general.xml has syntax
errors in the comments. This patch fixes them.

Change-Id: I45b77157084c312d5dc57daf28161c93a1f87d0f
Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com>
---
M exclude-filters-general.xml
1 file changed, 22 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/18642/1

diff --git a/exclude-filters-general.xml b/exclude-filters-general.xml
index f5d322e..f0ba0ec 100644
--- a/exclude-filters-general.xml
+++ b/exclude-filters-general.xml
@@ -1,99 +1,99 @@
 <FindBugsFilter>
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     Dm: Reliance on default encoding (DM_DEFAULT_ENCODING)
-    --!>
+    -->
     <Match>
         <Bug code="Dm" />
     </Match>
 
-    <--
+    <!--
     TBD:
     findbugs reason:
     EI: May expose internal representation by returning reference to mutable 
object (EI_EXPOSE_REP)
-    --!>
+    -->
     <Match>
         <Bug code="EI" />
     </Match>
 
-    <--
+    <!--
     TBD:
     findbugs reason:
     EI2: May expose internal representation by incorporating reference to 
mutable object (EI_EXPOSE_REP2)
-    --!>
+    -->
     <Match>
         <Bug code="EI2" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     MS: May expose internal static state by storing a mutable object into a 
static field (EI_EXPOSE_STATIC_REP2)
-    --!>
+    -->
     <Match>
         <Bug code="MS" />
     </Match>
 
-    <--
+    <!--
     TBD:
     findbugs reason:
     Eq: Class doesnt override equals in superclass (EQ_DOESNT_OVERRIDE_EQUALS)
-    --!>
+    -->
     <Match>
         <Bug code="Eq" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     IS: Inconsistent synchronization (IS2_INCONSISTENT_SYNC)
-    --!>
+    -->
     <Match>
         <Bug code="IS" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     REC: Exception is caught when Exception is not thrown (REC_CATCH_EXCEPTION)
-    --!>
+    -->
     <Match>
         <Bug code="REC" />
     </Match>
 
-    <--
+    <!--
     TBD:
     findbugs reason:
     Se: Non-transient non-serializable instance field in serializable class 
(SE_BAD_FIELD)
-    --!>
+    -->
     <Match>
         <Bug code="Se" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     SF: Switch statement found where default case is missing 
(SF_SWITCH_NO_DEFAULT)
-    --!>
+    -->
     <Match>
         <Bug code="SF" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     SIC: Should be a static inner class (SIC_INNER_SHOULD_BE_STATIC)
-    --!>
+    -->
     <Match>
         <Bug code="SIC" />
     </Match>
 
-    <--
+    <!--
     Currently Ignoring.
     findbugs reason:
     ST: Write to static field from instance method 
(ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
-    --!>
+    -->
     <Match>
         <Bug code="ST" />
     </Match>


-- 
To view, visit http://gerrit.ovirt.org/18642
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45b77157084c312d5dc57daf28161c93a1f87d0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to