[Engine-patches] Change in ovirt-engine[master]: engine: Inline a method

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Inline a method
......................................................................

engine: Inline a method

The method is inlined to match the other test convention.

Change-Id: I92ca9d112216794d3c63b8f54e33c7f21488b9dd
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/18635/1

diff --git 
a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
 
b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
index 8604e8d..20a70e4 100644
--- 
a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
+++ 
b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
@@ -12,11 +12,11 @@
         String[] straValid = new String[] { "www_redhat_com", "127001", 
"www_REDHAT_1" };
         String[] straInvalid = new String[] { "www.redhatcom", "me@localhost", 
"no/worries" };
         for (String s : straValid) {
-            assertTrue("Valid strings: " + s, !containsIlegalCharacters(s));
+            assertTrue("Valid strings: " + s, 
Pattern.matches(ValidationUtils.NO_SPECIAL_CHARACTERS, s));
         }
 
         for (String s : straInvalid) {
-            assertTrue("Invalid strings: " + s, containsIlegalCharacters(s));
+            assertTrue("Invalid strings: " + s, 
!Pattern.matches(ValidationUtils.NO_SPECIAL_CHARACTERS, s));
         }
     }
 
@@ -50,9 +50,5 @@
             assertTrue("Invalid strings (trimming whitespaces)",
                     
!Pattern.matches(ValidationUtils.NO_TRIMMING_WHITE_SPACES_PATTERN, s));
         }
-    }
-
-    private static boolean containsIlegalCharacters(String s) {
-        return !Pattern.matches(ValidationUtils.NO_SPECIAL_CHARACTERS, s);
     }
 }


-- 
To view, visit http://gerrit.ovirt.org/18635
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92ca9d112216794d3c63b8f54e33c7f21488b9dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches