Yaniv Bronhaim has uploaded a new change for review. Change subject: webadmin: Fixing validation of Auth Ssh Port ......................................................................
webadmin: Fixing validation of Auth Ssh Port The field's validation was set but without using the getIsValid as part of the general tab validation. Clicking OK forwarded the user to PM page instead of failing the operation. Reviewed-In: http://gerrit.ovirt.org/#/c/18359 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987910 Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/18625/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index 5561255..616f6c9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -1584,7 +1584,6 @@ new LengthValidation(255), new HostAddressValidation() }); - getPort().validateEntity(new IValidation[] {new NotEmptyValidation(), new IntegerValidation(1, 65535)}); getAuthSshPort().validateEntity(new IValidation[] {new NotEmptyValidation(), new IntegerValidation(1, 65535)}); if ((Boolean) getConsoleAddressEnabled().getEntity()) { @@ -1625,7 +1624,7 @@ setIsGeneralTabValid(getName().getIsValid() && getComment().getIsValid() && getHost().getIsValid() - && getPort().getIsValid() + && getAuthSshPort().getIsValid() && getCluster().getIsValid()); setIsPowerManagementTabValid(getManagementIp().getIsValid() -- To view, visit http://gerrit.ovirt.org/18625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
