Omer Frenkel has posted comments on this change.
Change subject: core, webadmin, engine: Added architecture support for VM and
Template
......................................................................
Patch Set 3:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 282: }
Line 283:
Line 284: if
(!vm.getArchitecture().equals(vds.getCpuName().getArchitecture())) {
Line 285: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_VM_DIFFERENT_ARCHITECTURES);
Line 286: }
the standard way is not to allow up hosts in the same cluster if migration
between them doesnt work
Line 287:
Line 288: return validate(new
SnapshotsValidator().vmNotDuringSnapshot(vm.getId()))
Line 289: // This check was added to prevent migration of VM
while its disks are being migrated
Line 290: // TODO: replace it with a better solution
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 220: VM vmFromParams = getParameters().getVm();
Line 221:
Line 222: if (StringUtils.isEmpty(getVdsGroup().getcpu_name())) {
Line 223: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_EMPTY_PROCESSOR_NAME);
Line 224: }
i dont understand this check, this command doesn't change the vm cluster, why
blocking vm update when cluster cpu is empty? (even though it shouldn't happen)
Line 225:
Line 226: if (!isVmExist()) {
Line 227:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST);
Line 228: return false;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 60: }
Line 61:
Line 62: if (StringUtils.isEmpty(getVdsGroup().getcpu_name())) {
Line 63: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_EMPTY_PROCESSOR_NAME);
Line 64: }
maybe worth failing only if cluster cpu is empty and architecture/os has
changed?
Line 65:
Line 66: VmTemplateHandler.UpdateDisksFromDb(mOldTemplate);
Line 67: if (mOldTemplate.getStatus() == VmTemplateStatus.Locked) {
Line 68: return
failCanDoAction(VdcBllMessages.VM_TEMPLATE_IS_LOCKED);
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 532: ACTION_LIST_CANNOT_BE_EMPTY=Actions list cannot be empty.
Line 533: ACTION_TYPE_FAILED_BOOKMARK_INVALID_ID=Cannot ${action} ${type}.
Bookmark ID is not valid.
Line 534: ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}.
Operation can be performed only when Host status is ${hostStatus}.
Line 535: ACTION_TYPE_FAILED_VDS_VM_DIFFERENT_ARCHITECTURES=Cannot ${action}
${type}. The source and destination architectures do not match.
Line 536: ACTION_TYPE_FAILED_VM_CLUSTER_DIFFERENT_ARCHITECTURES=Cannot
${action} ${type}. The VM and the destination cluster architectures do not
match.
please remove white space
Line 537: ACTION_TYPE_FAILED_MIGRATE_BETWEEN_TWO_CLUSTERS=Cannot ${action}
${type}. VM can be migrated only between Hosts in the same Cluster.\n\
Line 538: -Please select target Host in the same Cluster to run the VM.
Line 539: VDS_CANNOT_CHECK_VERSION_HOST_NON_RESPONSIVE=Cannot get Host version
when Host is in Non Responsive status.
Line 540: ACTION_TYPE_FAILED_VDS_INTERMITENT_CONNECTIVITY=Due to intermittent
connectivity to this Host, fence operations are not allowed at this time. The
system is trying to reconnect, please try again in 30 seconds.
--
To view, visit http://gerrit.ovirt.org/18227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
