Hello Yedidyah Bar David,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/18612

to review the following change.

Change subject: packaging: setup: Remove keys on cleanup after upgrade
......................................................................

packaging: setup: Remove keys on cleanup after upgrade

Remove engine_id_rsa, apache-ca.pem and apache.key.nopass on cleanup
after upgrade from 3.2.

Before this change, many other files were removed in such a case, but
not these ones.

Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7
Signed-off-by: Yedidyah Bar David <d...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/18612/1

diff --git a/packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py 
b/packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py
index ba4cc05..b5fb0c4 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py
@@ -61,6 +61,9 @@
             osetupcons.FileLocations.OVIRT_ENGINE_PKI_JBOSS_STORE,
             osetupcons.FileLocations.OVIRT_ENGINE_PKI_CA_CERT_CONF,
             osetupcons.FileLocations.OVIRT_ENGINE_PKI_CERT_CONF,
+            osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_SSH_KEY,
+            osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_KEY,
+            osetupcons.FileLocations.OVIRT_ENGINE_PKI_APACHE_CA_CERT,
         ):
             if os.path.exists(name):
                 uninstall_files.append(name)


-- 
To view, visit http://gerrit.ovirt.org/18612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to