Hello Yedidyah Bar David,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18598
to review the following change.
Change subject: packaging: setup: fix legacy wrappers package and name
......................................................................
packaging: setup: fix legacy wrappers package and name
1. move to setup package, as they should be in.
2. rename engine-check-upgrade to engine-check-update as it should.
Change-Id: Ie2a41b0653809af41c002b0241ce7b7ba35cd4c5
Signed-off-by: Yedidyah Bar David <d...@redhat.com>
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M Makefile
M ovirt-engine.spec.in
R packaging/bin/engine-check-update.sh
3 files changed, 5 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/18598/1
diff --git a/Makefile b/Makefile
index 0c51ec4..9103abb 100644
--- a/Makefile
+++ b/Makefile
@@ -380,7 +380,7 @@
# legacy-begin
ln -sf "$(DATA_DIR)/bin/engine-upgrade.sh"
"$(DESTDIR)$(BIN_DIR)/engine-upgrade"
- ln -sf "$(DATA_DIR)/bin/engine-check-upgrade.sh"
"$(DESTDIR)$(BIN_DIR)/engine-check-upgrade"
+ ln -sf "$(DATA_DIR)/bin/engine-check-update.sh"
"$(DESTDIR)$(BIN_DIR)/engine-check-update"
# legacy-end
gwt-debug:
diff --git a/ovirt-engine.spec.in b/ovirt-engine.spec.in
index c6df25c..962050b 100644
--- a/ovirt-engine.spec.in
+++ b/ovirt-engine.spec.in
@@ -733,8 +733,10 @@
# Legacy
# TODO: remove in 3.4
+%{_bindir}/engine-check-update
%{_bindir}/engine-upgrade
-%{_bindir}/engine-check-upgrade
+%{engine_data}/bin/engine-check-update.sh
+%{engine_data}/bin/engine-upgrade.sh
%files setup-plugin-allinone
@@ -820,11 +822,6 @@
%if %{ovirt_install_systemv}
%{_initddir}/ovirt-engine-notifier
%endif
-
-# Legacy
-# TODO: remove in 3.4
-%{engine_data}/bin/engine-check-upgrade.sh
-%{engine_data}/bin/engine-upgrade.sh
%changelog
* Thu Jan 17 2013 Juan Hernandez <juan.hernan...@redhat.com> - 3.3.0-1
diff --git a/packaging/bin/engine-check-upgrade.sh
b/packaging/bin/engine-check-update.sh
similarity index 66%
rename from packaging/bin/engine-check-upgrade.sh
rename to packaging/bin/engine-check-update.sh
index dcc1c28..4483720 100755
--- a/packaging/bin/engine-check-upgrade.sh
+++ b/packaging/bin/engine-check-update.sh
@@ -1,7 +1,7 @@
#!/bin/sh
cat >&2 <<__EOF__
-engine-check-upgrade is obsoleted by engine-upgrade-check.
+engine-check-update is obsoleted by engine-upgrade-check.
please run engine-upgrade-check for upgrading product or update settings.
__EOF__
--
To view, visit http://gerrit.ovirt.org/18598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2a41b0653809af41c002b0241ce7b7ba35cd4c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
