Moti Asayag has posted comments on this change.
Change subject: restapi: Allow untagging a network with vlan-id
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
Line 47: }
Line 48: if (model.isSetVlan()) {
Line 49:
Line 50: if (model.getVlan().getId() == null) {
Line 51: entity.setVlanId(null);
no special reason except the scary message on the catch block...in other wods:
fixed.
Line 52: } else {
Line 53: try {
Line 54: entity.setVlanId(model.getVlan().getId());
Line 55: } catch (NumberFormatException e) {
--
To view, visit http://gerrit.ovirt.org/18489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200dedd19412add194133a6f6554ecf6797f5a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
