Arik Hadas has posted comments on this change.
Change subject: core: keep locks for whole offline disk migration process
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 399: builder.append(String.format("$DiskName %1$s",
getDiskAlias()));
Line 400: }
Line 401: builder.append(String.format("$OperationType %1$s",
Line 402: ImageOperation.Move ==
getParameters().getOperation() ? "moved" : "copied"));
Line 403: cachedDiskIsBeingMigratedMessage = builder.toString();
this method is called twice - from getExclusiveLocks and getSharedLocks
methods, so we can create the message only once (even though I'm considering to
replace it with a simple "one of the disks of the VM is being moved/copied" -
so that we won't display too many messages to the user..)
Line 404: }
Line 405: return cachedDiskIsBeingMigratedMessage;
Line 406: }
Line 407:
--
To view, visit http://gerrit.ovirt.org/18530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89acf9f66bce647a7ecb2dd407e51a1ba03f4e17
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
