Michael Pasternak has posted comments on this change. Change subject: sdk: unclear error message when logging into cli with bad formatted url ......................................................................
Patch Set 1: Code-Review-1 (1 comment) .................................................... File src/ovirtsdk/infrastructure/connectionspool.py Line 115: LOCAL_HOST = 'localhost' Line 116: parsed_url = urlparse.urlparse(url) Line 117: domains = [parsed_url.hostname] Line 118: Line 119: if parsed_url.hostname == LOCAL_HOST or url == LOCAL_HOST: ravi, afaiu mentioned error is thrown from the httplib when it tries to extract port from the url, to fix this, i'd expect url validation via regex, allowed format is [1]. [1] http[s]://server:port/api thanks. Line 120: return domains.append(LOCAL_HOST + '.local') Line 121: Line 122: return domains Line 123: -- To view, visit http://gerrit.ovirt.org/16886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
